GH-153 - Fix disappearing empty folders#154
Merged
Merged
Conversation
auniverseaway
force-pushed
the
empty-folders
branch
from
July 12, 2025 13:08
9fc1f18 to
9d74e3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 75.61% 76.23% +0.62%
==========================================
Files 39 39
Lines 2243 2243
==========================================
+ Hits 1696 1710 +14
+ Misses 547 533 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kptdobe
approved these changes
Jul 14, 2025
Contributor
|
Should this PR remove https://github.com/adobe/da-admin/blob/main/test/storage/utils.t.js (broken test file), since the new test/storage/utils/list.test.js covers this? |
* Resolves an issue where empty folders would disappear in some circumstances * Increases test coverage
auniverseaway
force-pushed
the
empty-folders
branch
from
July 14, 2025 18:01
9d74e3b to
5dee2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: